Add __weakref__ support to core API classes #1533
Open
+82
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable weak referencing for Cython cdef classes: - Stream, Event, Context (cdef classes via pxd) - Buffer, LaunchConfig (cdef classes via pxd) Enable weak referencing for Python classes with __slots__: - Device, ObjectCode (added __weakref__ to __slots__) Note: Kernel already had __weakref__ in its __slots__. Memory resource classes inherit __weakref__ from _MemPool. Add test_weakref.py to verify all core API classes are weak-referenceable.
Andy-Jost
added
enhancement
Contributor
Contributor
Author
|
/ok to test 7cd2618 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enable weak referencing for core API classes that were previously not weak-referenceable.
Changes
object __weakref__to Cython cdef classes: Stream, Event, Context, Buffer, LaunchConfig"__weakref__"to__slots__for Python classes: Device, ObjectCodetest_weakref.pywith parameterized tests verifying all 8 core API classes are weak-referenceableNote: Kernel already had
__weakref__in its__slots__, and memory resource classes inherit from_MemPoolwhich already supports weak references.Test Plan
test_weakref.pycovers Device, Stream, Event, Context, Buffer, LaunchConfig, ObjectCode, Kernel