Skip to content

Fix race conditions on loop._ready_len #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fantix merged 1 commit into from
Jan 19, 2026
Merged

Fix race conditions on loop._ready_len #721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion uvloop/loop.pxd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ cdef class Loop:
object _default_executor
object _ready
set _queued_streams, _executing_streams
Py_ssize_t _ready_len

set _servers

Expand Down
8 changes: 2 additions & 6 deletions uvloop/loop.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,6 @@ cdef class Loop:
self._queued_streams = set()
self._executing_streams = set()
self._ready = col_deque()
self._ready_len = 0

self.handler_async = UVAsync.new(
self, <method_t>self._on_wake, self)
Expand Down Expand Up @@ -440,7 +439,7 @@ cdef class Loop:
self.handler_async.send()

cdef _on_wake(self):
if ((self._ready_len > 0 or self._stopping) and
if ((len(self._ready) > 0 or self._stopping) and
not self.handler_idle.running):
self.handler_idle.start()

Expand Down Expand Up @@ -481,8 +480,7 @@ cdef class Loop:
if len(self._queued_streams):
self._exec_queued_writes()

self._ready_len = len(self._ready)
if self._ready_len == 0 and self.handler_idle.running:
if len(self._ready) == 0 and self.handler_idle.running:
self.handler_idle.stop()

if self._stopping:
Expand Down Expand Up @@ -570,7 +568,6 @@ cdef class Loop:
for cb_handle in self._ready:
cb_handle.cancel()
self._ready.clear()
self._ready_len = 0

if self._polls:
for poll_handle in self._polls.values():
Expand Down Expand Up @@ -672,7 +669,6 @@ cdef class Loop:
cdef inline _append_ready_handle(self, Handle handle):
self._check_closed()
self._ready.append(handle)
self._ready_len += 1

cdef inline _call_soon_handle(self, Handle handle):
self._append_ready_handle(handle)
Expand Down
Loading