-
Notifications
You must be signed in to change notification settings - Fork 324
Prepare for JEP 500 #9557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Prepare for JEP 500 #9557
Conversation
This comment has been minimized.
This comment has been minimized.
d2219bc to
5c24855
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 11 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~de63e7031b, baseline=1.59.0-SNAPSHOT~567fb106f6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1085722
Total [baseline] (10.8 s) : 0, 10799812
Agent [candidate] (1.09 s) : 0, 1090462
Total [candidate] (10.921 s) : 0, 10921019
section appsec
Agent [baseline] (1.267 s) : 0, 1266666
Total [baseline] (11.009 s) : 0, 11008669
Agent [candidate] (1.281 s) : 0, 1280846
Total [candidate] (11.15 s) : 0, 11150318
section iast
Agent [baseline] (1.225 s) : 0, 1225024
Total [baseline] (10.097 s) : 0, 10096982
Agent [candidate] (1.234 s) : 0, 1234129
Total [candidate] (11.258 s) : 0, 11257693
section profiling
Agent [baseline] (1.205 s) : 0, 1204914
Total [baseline] (10.869 s) : 0, 10868767
Agent [candidate] (1.207 s) : 0, 1206963
Total [candidate] (11.061 s) : 0, 11061303
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~de63e7031b, baseline=1.59.0-SNAPSHOT~567fb106f6
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (651.788 ms) : 0, 651788
BytebuddyAgent [candidate] (654.632 ms) : 0, 654632
GlobalTracer [baseline] (283.361 ms) : 0, 283361
GlobalTracer [candidate] (284.467 ms) : 0, 284467
AppSec [baseline] (32.475 ms) : 0, 32475
AppSec [candidate] (32.696 ms) : 0, 32696
Debugger [baseline] (67.363 ms) : 0, 67363
Debugger [candidate] (68.292 ms) : 0, 68292
Remote Config [baseline] (618.49 µs) : 0, 618
Remote Config [candidate] (648.789 µs) : 0, 649
Telemetry [baseline] (8.846 ms) : 0, 8846
Telemetry [candidate] (8.917 ms) : 0, 8917
Flare Poller [baseline] (4.587 ms) : 0, 4587
Flare Poller [candidate] (3.969 ms) : 0, 3969
section appsec
crashtracking [baseline] (1.218 ms) : 0, 1218
crashtracking [candidate] (1.204 ms) : 0, 1204
BytebuddyAgent [baseline] (692.89 ms) : 0, 692890
BytebuddyAgent [candidate] (701.587 ms) : 0, 701587
GlobalTracer [baseline] (259.142 ms) : 0, 259142
GlobalTracer [candidate] (262.73 ms) : 0, 262730
IAST [baseline] (24.425 ms) : 0, 24425
IAST [candidate] (24.961 ms) : 0, 24961
AppSec [baseline] (173.031 ms) : 0, 173031
AppSec [candidate] (173.554 ms) : 0, 173554
Debugger [baseline] (66.405 ms) : 0, 66405
Debugger [candidate] (67.294 ms) : 0, 67294
Remote Config [baseline] (774.103 µs) : 0, 774
Remote Config [candidate] (779.366 µs) : 0, 779
Telemetry [baseline] (9.34 ms) : 0, 9340
Telemetry [candidate] (9.203 ms) : 0, 9203
Flare Poller [baseline] (3.788 ms) : 0, 3788
Flare Poller [candidate] (3.685 ms) : 0, 3685
section iast
crashtracking [baseline] (1.179 ms) : 0, 1179
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (792.199 ms) : 0, 792199
BytebuddyAgent [candidate] (797.205 ms) : 0, 797205
GlobalTracer [baseline] (256.799 ms) : 0, 256799
GlobalTracer [candidate] (259.132 ms) : 0, 259132
IAST [baseline] (27.178 ms) : 0, 27178
IAST [candidate] (27.326 ms) : 0, 27326
AppSec [baseline] (34.094 ms) : 0, 34094
AppSec [candidate] (35.386 ms) : 0, 35386
Debugger [baseline] (65.75 ms) : 0, 65750
Debugger [candidate] (65.646 ms) : 0, 65646
Remote Config [baseline] (586.654 µs) : 0, 587
Remote Config [candidate] (603.324 µs) : 0, 603
Telemetry [baseline] (8.452 ms) : 0, 8452
Telemetry [candidate] (8.567 ms) : 0, 8567
Flare Poller [baseline] (3.586 ms) : 0, 3586
Flare Poller [candidate] (3.58 ms) : 0, 3580
section profiling
crashtracking [baseline] (1.202 ms) : 0, 1202
crashtracking [candidate] (1.223 ms) : 0, 1223
BytebuddyAgent [baseline] (701.388 ms) : 0, 701388
BytebuddyAgent [candidate] (702.738 ms) : 0, 702738
GlobalTracer [baseline] (221.697 ms) : 0, 221697
GlobalTracer [candidate] (222.265 ms) : 0, 222265
AppSec [baseline] (32.14 ms) : 0, 32140
AppSec [candidate] (32.181 ms) : 0, 32181
Debugger [baseline] (67.985 ms) : 0, 67985
Debugger [candidate] (68.409 ms) : 0, 68409
Remote Config [baseline] (639.373 µs) : 0, 639
Remote Config [candidate] (676.495 µs) : 0, 676
Telemetry [baseline] (8.993 ms) : 0, 8993
Telemetry [candidate] (8.925 ms) : 0, 8925
Flare Poller [baseline] (3.843 ms) : 0, 3843
Flare Poller [candidate] (3.742 ms) : 0, 3742
ProfilingAgent [baseline] (97.403 ms) : 0, 97403
ProfilingAgent [candidate] (96.616 ms) : 0, 96616
Profiling [baseline] (97.986 ms) : 0, 97986
Profiling [candidate] (97.191 ms) : 0, 97191
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~de63e7031b, baseline=1.59.0-SNAPSHOT~567fb106f6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1085673
Total [baseline] (8.762 s) : 0, 8762200
Agent [candidate] (1.089 s) : 0, 1089099
Total [candidate] (8.784 s) : 0, 8783508
section iast
Agent [baseline] (1.225 s) : 0, 1225042
Total [baseline] (9.346 s) : 0, 9346133
Agent [candidate] (1.233 s) : 0, 1232554
Total [candidate] (9.341 s) : 0, 9341096
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~de63e7031b, baseline=1.59.0-SNAPSHOT~567fb106f6
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.18 ms) : 0, 1180
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (651.273 ms) : 0, 651273
BytebuddyAgent [candidate] (653.847 ms) : 0, 653847
GlobalTracer [baseline] (284.353 ms) : 0, 284353
GlobalTracer [candidate] (284.892 ms) : 0, 284892
AppSec [baseline] (32.67 ms) : 0, 32670
AppSec [candidate] (32.642 ms) : 0, 32642
Debugger [baseline] (67.42 ms) : 0, 67420
Debugger [candidate] (67.441 ms) : 0, 67441
Remote Config [baseline] (629.242 µs) : 0, 629
Remote Config [candidate] (613.313 µs) : 0, 613
Telemetry [baseline] (8.82 ms) : 0, 8820
Telemetry [candidate] (8.929 ms) : 0, 8929
Flare Poller [baseline] (3.898 ms) : 0, 3898
Flare Poller [candidate] (4.014 ms) : 0, 4014
section iast
crashtracking [baseline] (1.198 ms) : 0, 1198
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (793.467 ms) : 0, 793467
BytebuddyAgent [candidate] (797.234 ms) : 0, 797234
GlobalTracer [baseline] (256.728 ms) : 0, 256728
GlobalTracer [candidate] (258.334 ms) : 0, 258334
IAST [baseline] (26.841 ms) : 0, 26841
IAST [candidate] (27.197 ms) : 0, 27197
AppSec [baseline] (31.513 ms) : 0, 31513
AppSec [candidate] (32.819 ms) : 0, 32819
Debugger [baseline] (67.358 ms) : 0, 67358
Debugger [candidate] (67.502 ms) : 0, 67502
Remote Config [baseline] (593.555 µs) : 0, 594
Remote Config [candidate] (608.26 µs) : 0, 608
Telemetry [baseline] (8.391 ms) : 0, 8391
Telemetry [candidate] (8.505 ms) : 0, 8505
Flare Poller [baseline] (3.561 ms) : 0, 3561
Flare Poller [candidate] (3.581 ms) : 0, 3581
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~de63e7031b, baseline=1.59.0-SNAPSHOT~567fb106f6
dateFormat X
axisFormat %s
section baseline
no_agent (18.897 ms) : 18710, 19084
. : milestone, 18897,
appsec (18.802 ms) : 18608, 18995
. : milestone, 18802,
code_origins (17.851 ms) : 17673, 18029
. : milestone, 17851,
iast (17.633 ms) : 17458, 17808
. : milestone, 17633,
profiling (18.739 ms) : 18551, 18926
. : milestone, 18739,
tracing (17.717 ms) : 17539, 17894
. : milestone, 17717,
section candidate
no_agent (17.177 ms) : 17006, 17348
. : milestone, 17177,
appsec (19.126 ms) : 18933, 19320
. : milestone, 19126,
code_origins (17.79 ms) : 17613, 17968
. : milestone, 17790,
iast (17.691 ms) : 17518, 17865
. : milestone, 17691,
profiling (18.422 ms) : 18241, 18604
. : milestone, 18422,
tracing (17.584 ms) : 17410, 17758
. : milestone, 17584,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~de63e7031b, baseline=1.59.0-SNAPSHOT~567fb106f6
dateFormat X
axisFormat %s
section baseline
no_agent (1.27 ms) : 1256, 1283
. : milestone, 1270,
iast (3.169 ms) : 3133, 3206
. : milestone, 3169,
iast_FULL (5.811 ms) : 5753, 5869
. : milestone, 5811,
iast_GLOBAL (3.532 ms) : 3479, 3584
. : milestone, 3532,
profiling (2.032 ms) : 2014, 2050
. : milestone, 2032,
tracing (1.811 ms) : 1795, 1827
. : milestone, 1811,
section candidate
no_agent (1.216 ms) : 1202, 1230
. : milestone, 1216,
iast (3.088 ms) : 3043, 3132
. : milestone, 3088,
iast_FULL (5.704 ms) : 5648, 5761
. : milestone, 5704,
iast_GLOBAL (3.669 ms) : 3609, 3730
. : milestone, 3669,
profiling (2.055 ms) : 2035, 2074
. : milestone, 2055,
tracing (1.804 ms) : 1788, 1820
. : milestone, 1804,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~de63e7031b, baseline=1.59.0-SNAPSHOT~567fb106f6
dateFormat X
axisFormat %s
section baseline
no_agent (15.029 s) : 15029000, 15029000
. : milestone, 15029000,
appsec (14.824 s) : 14824000, 14824000
. : milestone, 14824000,
iast (18.093 s) : 18093000, 18093000
. : milestone, 18093000,
iast_GLOBAL (17.59 s) : 17590000, 17590000
. : milestone, 17590000,
profiling (14.656 s) : 14656000, 14656000
. : milestone, 14656000,
tracing (14.859 s) : 14859000, 14859000
. : milestone, 14859000,
section candidate
no_agent (15.555 s) : 15555000, 15555000
. : milestone, 15555000,
appsec (14.886 s) : 14886000, 14886000
. : milestone, 14886000,
iast (17.931 s) : 17931000, 17931000
. : milestone, 17931000,
iast_GLOBAL (17.693 s) : 17693000, 17693000
. : milestone, 17693000,
profiling (15.297 s) : 15297000, 15297000
. : milestone, 15297000,
tracing (14.861 s) : 14861000, 14861000
. : milestone, 14861000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~de63e7031b, baseline=1.59.0-SNAPSHOT~567fb106f6
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1459, 1482
. : milestone, 1471,
appsec (3.697 ms) : 3478, 3916
. : milestone, 3697,
iast (2.2 ms) : 2136, 2265
. : milestone, 2200,
iast_GLOBAL (2.246 ms) : 2181, 2311
. : milestone, 2246,
profiling (2.083 ms) : 2029, 2138
. : milestone, 2083,
tracing (2.039 ms) : 1988, 2090
. : milestone, 2039,
section candidate
no_agent (1.466 ms) : 1455, 1478
. : milestone, 1466,
appsec (3.708 ms) : 3489, 3927
. : milestone, 3708,
iast (2.203 ms) : 2138, 2268
. : milestone, 2203,
iast_GLOBAL (2.238 ms) : 2173, 2303
. : milestone, 2238,
profiling (2.066 ms) : 2013, 2119
. : milestone, 2066,
tracing (2.039 ms) : 1988, 2090
. : milestone, 2039,
|
5c24855 to
d906b86
Compare
d906b86 to
5ad4f5e
Compare
|
Will we be forbidding |
|
We won't. Quick quote from my doc about the topic:
|
|
Going back to draft to carefully evaluate and document each calls. |
|
This pull request has been marked as stale because it has not had activity over the past quarter. It will be closed in 7 days if no further activity occurs. Feel free to reopen the PR if you are still working on it. |
|
Let see if it makes the Q1 planning |
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (310.163 µs) : 284, 336
. : milestone, 310,
basic (276.486 µs) : 270, 283
. : milestone, 276,
loop (8.957 ms) : 8954, 8961
. : milestone, 8957,
section candidate
noprobe (321.296 µs) : 275, 368
. : milestone, 321,
basic (277.931 µs) : 271, 285
. : milestone, 278,
loop (8.959 ms) : 8955, 8964
. : milestone, 8959,
|
What Does This Do
This PR adds methods that may mutate final fields to the list of ForbiddenAPIs. It also identifies current use-cases of these methods and whether or not the usage will need to be changed.
Motivation
Let's "Prepare to Make Final Mean Final". Starting in Java 26, mutating final fields will emit warnings, and in a future release, this behavior will result in exceptions.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: APMLP-594