[SSF-108] Pantry food request management backend updates #82
+987
−328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dburkhart07
requested changes
Jan 19, 2026
dburkhart07
left a comment
dburkhart07
left a comment
There was a problem hiding this comment.
Few initial things, but looks pretty good so far
Yurika-Kan
reviewed
Jan 21, 2026
Yurika-Kan
requested changes
Jan 22, 2026
…-request-management-backend-route
Yurika-Kan
approved these changes
Jan 25, 2026
Collaborator
Yurika-Kan
left a comment
Yurika-Kan
left a comment
There was a problem hiding this comment.
left a nit comment but approving! looks good awesome job:)
dburkhart07
requested changes
Jan 25, 2026
dburkhart07
left a comment
dburkhart07
left a comment
There was a problem hiding this comment.
Few small things, also see slack comments.
Juwang110
added a commit
that referenced
this pull request
Jan 25, 2026
This reverts commit bed4144.
Juwang110
added a commit
that referenced
this pull request
Jan 25, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes https://vidushimisra.atlassian.net/browse/SSF-108
📝 Description
In terms of code changes it was mainly defining the new backend route and writing tests for that. The backend route I added is:
@get('/get-all-order-details/:requestId'). I also had to do some refactoring to transition from one associated order to a list of them.
Also, right now the request management page is outdated. For one, it is still associating one order with one request and for another, request management and order management is now being split into to pages. I had to refactor this outdated page for the updated request type and I chose to simply use the first order in the orders list (orders[0]) and have everything else be the same. Thus, this page does not work as intended but it can still be loaded. This change is just a placeholder for now, the new design pages will take over. The associated route is: request-form/:pantryId
✔️ Verification
I used swagger to verify my backend route worked as expected and I wrote some jest tests to ensure this. I added controller and service tests for the @get('/get-all-order-details/:requestId') route.
🏕️ (Optional) Future Work / Notes
The request form frontend is outdated and my refactoring of it to account for the orders list is just a placeholder. This will be overwritten in the future.