[SSF-79] Improve Peformance for Log New Donation Form Modal #58

dburkhart07 · 2025-10-25T23:46:29Z

ℹ️ Issue

Closes #79

📝 Description

Created new endpoint to go through each donation item, and make a call to the service function
Added validation for the donationId each time
Added tests for the createDonationItem and createMultipleDonationItems controllers

✔️ Verification

Ensured only 1 api call was being made via console logs

Successful confirmation of 1 api call being made:

🏕️ (Optional) Future Work / Notes

Still need to write tests for the rest of the controllers, as well as the services. We are holding off on service tests for now though, pending a potential change in how we do testing.

…n/error handling

amywng

can you change the field in donationItems entity to donationId instead of donation_id, also merge main so i can run it w/o issues

apps/frontend/src/components/forms/donationDetailsModal.tsx

apps/frontend/src/components/forms/newDonationFormModal.tsx

package.json

apps/backend/src/donationItems/donationItems.controller.spec.ts

apps/frontend/src/components/forms/deliveryConfirmationModal.tsx

apps/frontend/src/components/forms/newDonationFormModal.tsx

amywng · 2025-12-06T19:06:52Z

apps/frontend/src/components/forms/newDonationFormModal.tsx

      totalValue = 0;

    updatedRows.forEach((row) => {
      if (row.numItems && row.ozPerItem && row.valuePerItem) {


imo i feel like we shouldn't wait til they're all filled out, but update as any row is changed (also know this isn't part of your ticket but food for thought ig

apps/backend/src/donationItems/donationItems.controller.ts

apps/backend/src/donationItems/dtos/create-donation-items.dto.ts

apps/backend/src/donationItems/dtos/create-donationItems.dto.ts

apps/frontend/src/components/forms/newDonationFormModal.tsx

apps/backend/src/donationItems/dtos/create-donationItems.dto.ts

apps/backend/src/donationItems/donationItems.entity.ts

apps/backend/src/donationItems/dtos/create-donation-items.dto.ts

apps/frontend/src/components/forms/donationDetailsModal.tsx

apps/frontend/src/theme.ts

apps/backend/src/donationItems/donationItems.controller.spec.ts

apps/frontend/src/components/forms/newDonationFormModal.tsx

apps/frontend/src/api/apiClient.ts

amywng

we need to add validation to the form because i was able to submit an invalid entry and it added it to the database but i'm going to say that is whoever does the new form's job

apps/frontend/src/components/forms/newDonationFormModal.tsx

amywng

couple small comments. once justin's pr goes in you'll have to fix the status stuff but i'm approving

apps/backend/src/donationItems/donationItems.controller.ts

apps/frontend/src/components/forms/donationDetailsModal.tsx

apps/frontend/src/components/forms/newDonationFormModal.tsx

apps/backend/src/donationItems/donationItems.controller.ts

Yurika-Kan · 2026-01-15T18:00:43Z

apps/frontend/src/components/forms/newDonationFormModal.tsx

      return;
    }

    onClose();


what's the reason we close it first? it works asyncly is what i am understanding how you can set this as closed before api call finishes. is this just better design

Not really, you make a good point. I think it should not really matter where we place it, but for error handling, it is probably better for them to receive some browser alert if something went wrong before closing it. I just changed the location!

Yurika-Kan · 2026-01-15T18:02:22Z

apps/frontend/src/components/forms/newDonationFormModal.tsx

      const donationId = donationResponse?.donationId;

-      // Automatically update the page after creating new donation
      onDonationSuccess();


same thing here of calling this end result function before the api await call a few lines after!

Also changed for same reason!

Yurika-Kan · 2026-01-15T18:11:40Z

apps/frontend/src/components/forms/donationDetailsModal.tsx

+    if (!acc[item.foodType]) acc[item.foodType] = [];
    acc[item.foodType].push(item);
    return acc;
  }, {} as Record<string, DonationItem[]>);


trying to think of a case where this could be null/undef since Record<string, DonationItem[]> technically could take any string, which means it could be set to acc[null].push(item) for example. thoughts on handling for null/undef here?

Another really good point. We have been in the process of making sure our backend and frontend types match, and this caught an issue we had. I have changed the frontend DonationItem so that the type is of FoodType enum. This will make it so that we cannot have null/undef cases, since it always needs to be one of those options now, and can stay handled as this.

apps/backend/src/donationItems/donationItems.controller.spec.ts

Yurika-Kan

test

Yurika-Kan

good! just minor clarifications

apps/backend/src/donationItems/donationItems.controller.ts

apps/frontend/src/components/forms/donationDetailsModal.tsx

Yurika-Kan

some more comments ><

Yurika-Kan · 2026-01-25T20:59:30Z

apps/frontend/src/types/types.ts

+    reservedQuantity: number;
+    ozPerItem: number;
+    estimatedValue: number;
+    foodType: string;


should this be the enum type defined above

Yurika-Kan · 2026-01-25T22:23:53Z

apps/frontend/src/components/forms/newDonationFormModal.tsx

-      alert('Error submitting new donation');
+      alert('Error submitting new donation: ' + error);
    }
+    onClose();


nit but should we move onClose to inside the try catch so that is submission fails the modal stays open & user can fix issue

Yurika-Kan · 2026-01-25T22:28:30Z

apps/frontend/src/components/forms/newDonationFormModal.tsx

+                        <Table.Cell>
+                          <Input
+                            type="number"
+                            min={0}


should this be min={1} to match the backend dto ozPerItem being @min(1)

Yurika-Kan · 2026-01-25T22:29:52Z

apps/frontend/src/components/forms/newDonationFormModal.tsx

+                        <Table.Cell>
+                          <Input
+                            type="number"
+                            min={0}


same here with estimatedValue being min of 1

Yurika-Kan · 2026-01-25T22:35:11Z

apps/frontend/src/components/forms/newDonationFormModal.tsx

-      alert('Error submitting new donation');
+      alert('Error submitting new donation: ' + error);
    }
+    onClose();


would be better to have this inside the try catch so its not silently failing & the modal will not close even when the submission fails

Yurika-Kan · 2026-01-25T22:36:10Z

apps/frontend/src/components/forms/newDonationFormModal.tsx

+                        <Table.Cell>
+                          <Input
+                            type="number"
+                            min={0}


numitems is quantity in backend dto which should be min 1

amywng added the low priority label Nov 18, 2025

dburkhart07 force-pushed the ddb/SSF-79-improve-performance-log-new-donation-form branch from 3c5bca7 to 3c3e332 Compare November 30, 2025 02:52

dburkhart07 added 8 commits November 30, 2025 16:21

Created initial Api and frontend integration, awaiting some validatio…

c1c0485

…n/error handling

Changes for setting upstream

09d9357

Added tests for donation items controller only

3d95bbd

Final commit

706b59f

Final commit

9c47821

Resolved merge conflicts

ea1d063

Final commit

ec957b7

Prettier

20b9bbe

dburkhart07 force-pushed the ddb/SSF-79-improve-performance-log-new-donation-form branch from d73a38e to 20b9bbe Compare November 30, 2025 21:23

amywng requested changes Dec 4, 2025

View reviewed changes

dburkhart07 added 3 commits December 6, 2025 13:10

Resolved merge conflicts

8e773fe

prettier

98b5e25

Made changes

0c249bc

dburkhart07 requested a review from amywng December 6, 2025 18:21

amywng requested changes Dec 6, 2025

View reviewed changes

dburkhart07 added 3 commits December 6, 2025 15:32

Changes with one multiple donation item saving

c971104

Fixed DTO formatting

8548fc4

prettier

9c36a1c

dburkhart07 requested a review from amywng December 6, 2025 20:37

amywng requested changes Dec 6, 2025

View reviewed changes

apps/frontend/src/components/forms/newDonationFormModal.tsx Outdated Show resolved Hide resolved

apps/frontend/src/api/apiClient.ts Outdated Show resolved Hide resolved

dburkhart07 added 2 commits December 7, 2025 01:55

Fixed changes and rewrote test

cc585cf

prettier

9451c7b

dburkhart07 requested a review from amywng December 7, 2025 06:56

amywng requested changes Dec 7, 2025

View reviewed changes

apps/frontend/src/components/forms/newDonationFormModal.tsx Show resolved Hide resolved

dburkhart07 requested a review from amywng December 8, 2025 06:00

amywng approved these changes Dec 8, 2025

View reviewed changes

apps/backend/src/donationItems/donationItems.controller.ts Outdated Show resolved Hide resolved

apps/frontend/src/components/forms/donationDetailsModal.tsx Show resolved Hide resolved

apps/frontend/src/components/forms/newDonationFormModal.tsx Outdated Show resolved Hide resolved

Final commits

ee7ad64

dburkhart07 added 4 commits December 8, 2025 18:27

prettier

1106308

Resolved merge conficts

c0f4c1e

Resolved merge conflicts

79df911

Final commit

bc0e307

amywng reviewed Dec 10, 2025

View reviewed changes

apps/frontend/src/components/forms/newDonationFormModal.tsx Outdated Show resolved Hide resolved

Final commit

2f7c61a

sam-schu requested a review from Yurika-Kan January 1, 2026 19:01

Yurika-Kan reviewed Jan 15, 2026

View reviewed changes

apps/backend/src/donationItems/donationItems.controller.ts Show resolved Hide resolved

dburkhart07 requested a review from Yurika-Kan January 18, 2026 02:35

Yurika-Kan reviewed Jan 18, 2026

View reviewed changes

dburkhart07 added 4 commits January 19, 2026 15:22

Merged main

ccc073d

Merged main

aa6a0ab

Resolved comments

72e34dc

prettier

9ccc8df

dburkhart07 requested a review from Yurika-Kan January 19, 2026 20:42

Yurika-Kan requested changes Jan 23, 2026

View reviewed changes

apps/backend/src/donationItems/donationItems.controller.spec.ts Show resolved Hide resolved

Yurika-Kan self-requested a review January 23, 2026 01:30

Yurika-Kan requested changes Jan 23, 2026

View reviewed changes

apps/backend/src/donationItems/donationItems.controller.ts Show resolved Hide resolved

apps/frontend/src/components/forms/donationDetailsModal.tsx Show resolved Hide resolved

dburkhart07 requested a review from Yurika-Kan January 23, 2026 03:38

dburkhart07 added 2 commits January 25, 2026 13:30

Final commit

8656f5c

Merged main

eba7e50

Yurika-Kan requested changes Jan 25, 2026

View reviewed changes

[SSF-79] Improve Peformance for Log New Donation Form Modal #58

Are you sure you want to change the base?

[SSF-79] Improve Peformance for Log New Donation Form Modal #58

Uh oh!

Conversation

dburkhart07 commented Oct 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ℹ️ Issue

📝 Description

✔️ Verification

🏕️ (Optional) Future Work / Notes

Uh oh!

amywng left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

amywng left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

amywng left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Yurika-Kan Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Yurika-Kan Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Yurika-Kan left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Yurika-Kan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Yurika-Kan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

dburkhart07 commented Oct 25, 2025 •

edited

Loading

Yurika-Kan Jan 15, 2026 •

edited

Loading

Yurika-Kan Jan 15, 2026 •

edited

Loading

Yurika-Kan left a comment •

edited

Loading