Added logs and api response #269
Open
+142
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prooflesben
requested changes
Jan 25, 2026
Collaborator
prooflesben
left a comment
prooflesben
left a comment
There was a problem hiding this comment.
A lot of the warns should be errors. There are some warns where we send a 4** error. If something makes the method fail it should be an error logged. In auth.service lines 330-338 have no logging when an error is thrown. Some other places logging is missing esp when an error is thrown.
prooflesben
requested changes
Jan 25, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #254
📝 Description
✔️ Verification
🏕️ (Optional) Future Work / Notes