-
Notifications
You must be signed in to change notification settings - Fork 20
feat(cargo-codspeed): add internal build mode #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cargo-codspeed): add internal build mode #159
Conversation
Merging this PR will degrade performance by 19.27%
Performance Changes
Comparing |
GuillaumeLagrange
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
olgtm, assuming skipped benchmark are just because we need to rebase
7242105 to
693edb3
Compare
cargo-codspeed v4.3.0 (CodSpeedHQ/codspeed-rust#159) changed internal build mode mapping so `MeasurementMode::Simulation` now maps to `BuildMode::Analysis`, which changed the expected directory from `target/codspeed/simulation/` to `target/codspeed/analysis/`. Also updates CodSpeedHQ/action to v4.8.2. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
cargo-codspeed v4.3.0 (CodSpeedHQ/codspeed-rust#159) changed internal build mode mapping so `MeasurementMode::Simulation` now maps to `BuildMode::Analysis`, which changed the expected directory from `target/codspeed/simulation/` to `target/codspeed/analysis/`. Also updates CodSpeedHQ/action to v4.8.2. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
cargo-codspeed v4.3.0 (CodSpeedHQ/codspeed-rust#159) changed internal build mode mapping so `MeasurementMode::Simulation` now maps to `BuildMode::Analysis`, which changed the expected directory from `target/codspeed/simulation/` to `target/codspeed/analysis/`. Also updates CodSpeedHQ/action to v4.8.2. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
## Summary - Fix benchmark directory path: `target/codspeed/simulation/` → `target/codspeed/analysis/` - Update CodSpeedHQ/action v4.7.0 → v4.8.2 ## Root Cause cargo-codspeed v4.3.0 ([CodSpeedHQ/codspeed-rust#159](CodSpeedHQ/codspeed-rust#159)) changed internal build mode mapping so `MeasurementMode::Simulation` now maps to `BuildMode::Analysis`, which changed the expected directory from `target/codspeed/simulation/` to `target/codspeed/analysis/`. ## Test plan - CI benchmark jobs should pass 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
No description provided.