Skip to content

Conversation

@not-matthias
Copy link
Member

  • Fixes an edge case where remaining commands aren't cleared from the buffer
  • Removes 128B allocations that aren't from the benchmark

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 20, 2026

CodSpeed Performance Report

Merging this PR will degrade performance by 32.21%

Comparing cod-2056-bump-instrument-hooks-in-codspeed-cpp (cebedf1) with main (ad31ee3)

Summary

⚡ 16 improved benchmarks
❌ 11 regressed benchmarks
✅ 355 untouched benchmarks
🆕 78 new benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime BM_Vector_PushBack[10] 321.7 ns 281.8 ns +14.15%
WallTime BM_Vector_Reserve[10] 75.6 ns 67.2 ns +12.43%
WallTime BM_Vector_PushBack[10000] 34.1 µs 39.2 µs -13.02%
WallTime BM_Vector_PushBack[1000] 3.7 µs 4.2 µs -11.54%
WallTime BM_Vector_Reserve[10000] 31.2 µs 36 µs -13.24%
WallTime BM_Vector_Reserve[100] 350.7 ns 390.3 ns -10.16%
WallTime BM_Vector_Reserve[1000] 3.2 µs 3.6 µs -11.71%
🆕 Memory BM_sleep_1us N/A 0 B N/A
🆕 Memory BM_large_setup N/A 0 B N/A
🆕 Memory BM_RLE_Encode_LargeRuns[10000] N/A 722 B N/A
🆕 Memory BM_short_name N/A 0 B N/A
🆕 Memory BarTest[MyFixture] N/A 0 B N/A
🆕 Memory BM_Template[std\:\:string] N/A 32 B N/A
🆕 Memory BM_String_Concatenation[1000] N/A 2.8 KB N/A
🆕 Memory BM_memcpy[8192] N/A 0 B N/A
🆕 Memory BM_with_multiple_args[10/20] N/A 0 B N/A
🆕 Memory BM_FibonacciRecursive[35] N/A 0 B N/A
🆕 Memory BM_custom_multi[100/200] N/A 0 B N/A
🆕 Memory TestB[MyTemplate2, int, double] N/A 0 B N/A
🆕 Memory BM_String_Reserve[10000] N/A 9.8 KB N/A
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@not-matthias not-matthias force-pushed the cod-2056-bump-instrument-hooks-in-codspeed-cpp branch 3 times, most recently from 4e93b2e to 1cc7b1a Compare January 21, 2026 11:12
@avalanche-staging
Copy link

avalanche-staging bot commented Jan 21, 2026

CodSpeed Performance Report

Congrats! CodSpeed is installed 🎉

🆕 468 new benchmarks were detected.

You will start to see performance impacts in the reports once the benchmarks are run from your default branch.

Detected benchmarks


ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@not-matthias not-matthias force-pushed the cod-2056-bump-instrument-hooks-in-codspeed-cpp branch from 5aa8fae to cebedf1 Compare January 21, 2026 12:06
Copy link
Contributor

@GuillaumeLagrange GuillaumeLagrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@not-matthias not-matthias merged commit cebedf1 into main Jan 21, 2026
26 of 27 checks passed
@not-matthias not-matthias deleted the cod-2056-bump-instrument-hooks-in-codspeed-cpp branch January 21, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants