Fix/invoke llm tool call handling #674
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a GitHub Action and local script that compares the branch to main, detects deleted markdown files, and ensures each has a corresponding redirect entry in next.config.ts. Prevents broken bookmarks and SEO issues. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…t checker Content moves: - Move guides/agent-frameworks/* to get-started/agent-frameworks/* - Move guides/tool-calling/mcp-clients/* to get-started/mcp-clients/* - Add wildcard redirects for moved content - Fix stale _meta.tsx references Redirect checker enhancements: - Interactive mode prompts for redirect destinations - Validates existing redirects for placeholder text (REPLACE_WITH, TODO, FIXME) - Catches circular redirects (source == destination) - Verifies destination pages exist - Detects both deletes and renames Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Fail with error when base branch is unavailable instead of silent success - Fix root page URL path handling (app/en/page.mdx -> /:locale) - Only check page.md/mdx files (skip non-routable markdown like README.md) - Use cut with tab delimiter instead of awk to handle filenames with spaces Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Adjusted the script to use cut for field extraction, improving handling of deleted and renamed page files. - Updated informational messages to redirect stderr, ensuring clarity in user prompts. This improves the user experience when managing redirects in the Arcade platform.
Companion to check-redirects.sh - this script reads redirect mappings from next.config.ts and updates any internal links in MDX/TSX files that point to old (redirected) paths. Usage: ./scripts/update-internal-links.sh [--dry-run] Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Update internal links and redirect destinations that were incorrectly pointing to /guides/ paths when the actual pages are under /get-started/: - /guides/agent-frameworks/* -> /get-started/agent-frameworks/* - /guides/tool-calling/mcp-clients/* -> /get-started/mcp-clients/* - /home/quickstart -> /get-started/quickstarts/call-tool-agent - /home/hosting-overview -> /guides/deployment-hosting Files updated across MDX docs, TSX components, and next.config.ts redirects. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Changes to check-redirects.sh: - Add --auto-fix flag that automatically inserts redirect entries into next.config.ts when pages are deleted - Uses placeholder destinations that must be replaced before merge Changes to pre-commit hook: - When page files are deleted, runs check-redirects.sh --auto-fix - Auto-adds redirect entries and stages next.config.ts - Blocks commit until placeholder destinations are replaced - When next.config.ts is staged, runs update-internal-links.sh to fix internal links pointing to redirected paths Workflow: 1. Delete page -> commit blocked, redirect entry auto-added 2. Update placeholder destination in next.config.ts 3. Commit again -> internal links auto-fixed, commit succeeds Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The perl -pe approach failed because redirect entry strings contain special characters (colons, slashes, quotes) that broke perl syntax. Switch to awk with a temp file approach which handles arbitrary content safely. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
When a redirect points to a destination that itself has a redirect (a chain like A → B → C), the script now: 1. Detects the chain during validation 2. In --auto-fix mode, automatically collapses it (A → C) 3. Updates next.config.ts with the collapsed redirect This handles the case where an old redirect (e.g., from a previous migration) points to a page that is now being deleted/moved. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Pre-commit hook now shows appropriate message based on error type: - Placeholder message only when REPLACE_WITH_NEW_PATH exists - Generic "fix issues shown above" for other errors - Invalid redirect errors now include step-by-step fix instructions Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Accept main's llms.txt (auto-generated) - Include workflow fix (set -o pipefail) - Include new Copilot Studio MCP client docs - Include LLM setup guide Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Move page from guides/ to get-started/agent-frameworks/ (correct location) - Update internal links in Next Steps section Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The invoke_llm function was failing to append the assistant's message (containing tool_calls) to history before appending tool result messages. This is required by the OpenAI API spec - the conversation must include the assistant message with tool_calls before the tool response messages. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
Maybe wait till some of the other PRs are merged. This is a dog's dinner |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| height={STEP_4_HEIGHT / IMAGE_SCALE_FACTOR} | ||
| /> | ||
|
|
||
| </Steps> |
There was a problem hiding this comment.
New Copilot Studio page placed in wrong directory
High Severity
The new Copilot Studio documentation page is added at app/en/guides/tool-calling/mcp-clients/copilot-studio/page.mdx, but a redirect exists from /guides/tool-calling/mcp-clients/:path* to /get-started/mcp-clients/:path*. The _meta.tsx and mcp-client-grid.tsx in /get-started/mcp-clients/ reference copilot-studio, expecting a page there, but no page exists at app/en/get-started/mcp-clients/copilot-studio/page.mdx. This causes the page to redirect to a 404 and creates broken navigation links.
Additional Locations (2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cursorbot caught this in another PR. Wanted to flag it to @torresmateo in case it's important
Note
Introduces redirect governance and major docs IA updates.
check-redirects.ymland shell scriptsscripts/check-redirects.sh+scripts/update-internal-links.shto detect missing redirects for deletedpage.md(x)files, auto-add entries, collapse redirect chains, and update internal links; wired into.husky/pre-committo block commits with placeholders/get-started/*; updates many internal links and UI components (e.g.,ToolFooter, landing page) to new pathsnext.config.tsredirects()with comprehensive mappings from old/home/*and/guides/*paths to/get-started/*, plus aliases for legacy routesget-started/agent-frameworks/setup-arcade-with-your-llm-python(Python harness guide) and MCP client page for Microsoft Copilot Studio; updates MCP client grid and metadatallms.txtentriesWritten by Cursor Bugbot for commit 149800d. This will update automatically on new commits. Configure here.