Skip to content

Feature: Use pre-commit.ci #959

@CarliJoy

Description

@CarliJoy

Currently we use the following in our ci workflow

      - name: Execute pre-commit handler
        continue-on-error: true
        run: |
          poetry run pre-commit run check-toml
          poetry run pre-commit run trailing-whitespace
          poetry run pre-commit run end-of-file-fixer
          poetry run pre-commit run ruff
          poetry run pre-commit run ruff-format
      - name: Execute mypy
        run: |
          make mypy-core-report
          make mypy-core

So we run all hooks but the mypy hool and then run mypy.

I suggest we use https://pre-commit.ci/

This service run the pre-commit hooks and offers a skip option for ci, so we have one file where to define which hooks should run in ci and locally.

It also has speed advantages and can commit changes of ruff back to MR.
It also updates the pre-commit file automatically, creating a PR.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions