diff --git a/extensions/ql-vscode/src/view/common/CodePaths/CodeFlowsDropdown.tsx b/extensions/ql-vscode/src/view/common/CodePaths/CodeFlowsDropdown.tsx index cc232060f0a..12af1de42d2 100644 --- a/extensions/ql-vscode/src/view/common/CodePaths/CodeFlowsDropdown.tsx +++ b/extensions/ql-vscode/src/view/common/CodePaths/CodeFlowsDropdown.tsx @@ -1,4 +1,4 @@ -import type { ChangeEvent, SetStateAction } from "react"; +import type { SetStateAction } from "react"; import { useCallback } from "react"; import { VscodeOption, @@ -25,8 +25,8 @@ export const CodeFlowsDropdown = ({ setSelectedCodeFlow, }: CodeFlowsDropdownProps) => { const handleChange = useCallback( - (e: ChangeEvent) => { - const selectedOption = e.target; + (e: Event) => { + const selectedOption = e.target as HTMLSelectElement; const selectedIndex = parseInt(selectedOption.value); setSelectedCodeFlow(codeFlows[selectedIndex]); }, diff --git a/extensions/ql-vscode/src/view/common/DataGrid.tsx b/extensions/ql-vscode/src/view/common/DataGrid.tsx index a8bce90b0a3..2dc3bfa95ad 100644 --- a/extensions/ql-vscode/src/view/common/DataGrid.tsx +++ b/extensions/ql-vscode/src/view/common/DataGrid.tsx @@ -83,7 +83,7 @@ export const DataGridRow = forwardRef( "data-testid": testId, onClick, }: DataGridRowProps, - ref?: React.Ref, + ref?: React.Ref, ) => ( , + ref?: React.Ref, ) => { return ( ` +const StyledButton = styled.button<{ $size?: Size }>` background: none; color: var(--vscode-textLink-foreground); border: none; diff --git a/extensions/ql-vscode/src/view/model-alerts/ModelAlertsSort.tsx b/extensions/ql-vscode/src/view/model-alerts/ModelAlertsSort.tsx index e5d4e9f2eb6..c2053575587 100644 --- a/extensions/ql-vscode/src/view/model-alerts/ModelAlertsSort.tsx +++ b/extensions/ql-vscode/src/view/model-alerts/ModelAlertsSort.tsx @@ -20,7 +20,7 @@ type Props = { export const ModelAlertsSort = ({ value, onChange, className }: Props) => { const handleInput = useCallback( - (e: InputEvent) => { + (e: Event) => { const target = e.target as HTMLSelectElement; onChange(target.value as SortKey); diff --git a/extensions/ql-vscode/src/view/model-editor/MethodRow.tsx b/extensions/ql-vscode/src/view/model-editor/MethodRow.tsx index 03a1abdd44c..c3c6b646f79 100644 --- a/extensions/ql-vscode/src/view/model-editor/MethodRow.tsx +++ b/extensions/ql-vscode/src/view/model-editor/MethodRow.tsx @@ -85,7 +85,7 @@ export type MethodRowProps = { export const MethodRow = (props: MethodRowProps) => { const { method, methodCanBeModeled, revealedMethodSignature } = props; - const ref = useRef(undefined); + const ref = useRef(null); useEffect(() => { if (method.signature === revealedMethodSignature) { @@ -103,7 +103,7 @@ export const MethodRow = (props: MethodRowProps) => { } }; -const ModelableMethodRow = forwardRef( +const ModelableMethodRow = forwardRef( (props: MethodRowProps, ref) => { const { method, @@ -359,39 +359,38 @@ const ModelableMethodRow = forwardRef( ); ModelableMethodRow.displayName = "ModelableMethodRow"; -const UnmodelableMethodRow = forwardRef< - HTMLElement | undefined, - MethodRowProps ->((props: MethodRowProps, ref) => { - const { method, viewState, revealedMethodSignature } = props; - - const jumpToMethod = useCallback( - () => sendJumpToMethodMessage(method), - [method], - ); - - return ( - - - - - - - {viewState.mode === Mode.Application && ( - - {method.usages.length} - - )} - View - - - Method already modeled - - ); -}); +const UnmodelableMethodRow = forwardRef( + (props: MethodRowProps, ref) => { + const { method, viewState, revealedMethodSignature } = props; + + const jumpToMethod = useCallback( + () => sendJumpToMethodMessage(method), + [method], + ); + + return ( + + + + + + + {viewState.mode === Mode.Application && ( + + {method.usages.length} + + )} + View + + + Method already modeled + + ); + }, +); UnmodelableMethodRow.displayName = "UnmodelableMethodRow"; function sendJumpToMethodMessage(method: Method) { diff --git a/extensions/ql-vscode/src/view/model-editor/ModelTypeTextbox.tsx b/extensions/ql-vscode/src/view/model-editor/ModelTypeTextbox.tsx index 69f9a0829b9..e9ba55c9a8a 100644 --- a/extensions/ql-vscode/src/view/model-editor/ModelTypeTextbox.tsx +++ b/extensions/ql-vscode/src/view/model-editor/ModelTypeTextbox.tsx @@ -1,4 +1,3 @@ -import type { ChangeEvent } from "react"; import { useCallback, useEffect, useState } from "react"; import type { ModeledMethod, @@ -33,8 +32,8 @@ export const ModelTypeTextbox = ({ setValue(modeledMethod[typeInfo]); }, [modeledMethod, typeInfo]); - const handleChange = useCallback((e: ChangeEvent) => { - const target = e.target as HTMLSelectElement; + const handleChange = useCallback((e: Event) => { + const target = e.target as HTMLInputElement; setValue(target.value); }, []); diff --git a/extensions/ql-vscode/src/view/variant-analysis/RepoRow.tsx b/extensions/ql-vscode/src/view/variant-analysis/RepoRow.tsx index 19edad08cc2..06fa7ec8705 100644 --- a/extensions/ql-vscode/src/view/variant-analysis/RepoRow.tsx +++ b/extensions/ql-vscode/src/view/variant-analysis/RepoRow.tsx @@ -1,4 +1,3 @@ -import type { ChangeEvent } from "react"; import { useCallback, useEffect, useState } from "react"; import { styled } from "styled-components"; import { VscodeCheckbox } from "@vscode-elements/react-elements"; @@ -229,9 +228,10 @@ export const RepoRow = ({ e.stopPropagation(); }, []); const onChangeCheckbox = useCallback( - (e: ChangeEvent) => { + (e: Event) => { + const target = e.target as HTMLInputElement; // This is called on first render, but we don't really care about this value - if (e.target.checked === undefined) { + if (target.checked === undefined) { return; } @@ -239,7 +239,7 @@ export const RepoRow = ({ return; } - onSelectedChange?.(repository.id, e.target.checked); + onSelectedChange?.(repository.id, target.checked); }, [onSelectedChange, repository], ); diff --git a/extensions/ql-vscode/src/view/variant-analysis/RepositoriesFilter.tsx b/extensions/ql-vscode/src/view/variant-analysis/RepositoriesFilter.tsx index 206b33586fb..8605296bcac 100644 --- a/extensions/ql-vscode/src/view/variant-analysis/RepositoriesFilter.tsx +++ b/extensions/ql-vscode/src/view/variant-analysis/RepositoriesFilter.tsx @@ -20,7 +20,7 @@ type Props = { export const RepositoriesFilter = ({ value, onChange, className }: Props) => { const handleInput = useCallback( - (e: InputEvent) => { + (e: Event) => { const target = e.target as HTMLSelectElement; onChange(target.value as FilterKey); diff --git a/extensions/ql-vscode/src/view/variant-analysis/RepositoriesResultFormat.tsx b/extensions/ql-vscode/src/view/variant-analysis/RepositoriesResultFormat.tsx index 380599017eb..cc7455bab25 100644 --- a/extensions/ql-vscode/src/view/variant-analysis/RepositoriesResultFormat.tsx +++ b/extensions/ql-vscode/src/view/variant-analysis/RepositoriesResultFormat.tsx @@ -24,7 +24,7 @@ export const RepositoriesResultFormat = ({ className, }: Props) => { const handleInput = useCallback( - (e: InputEvent) => { + (e: Event) => { const target = e.target as HTMLSelectElement; onChange(target.value as ResultFormat); diff --git a/extensions/ql-vscode/src/view/variant-analysis/RepositoriesSort.tsx b/extensions/ql-vscode/src/view/variant-analysis/RepositoriesSort.tsx index 96ec4c43dd4..b067b68d110 100644 --- a/extensions/ql-vscode/src/view/variant-analysis/RepositoriesSort.tsx +++ b/extensions/ql-vscode/src/view/variant-analysis/RepositoriesSort.tsx @@ -20,7 +20,7 @@ type Props = { export const RepositoriesSort = ({ value, onChange, className }: Props) => { const handleInput = useCallback( - (e: InputEvent) => { + (e: Event) => { const target = e.target as HTMLSelectElement; onChange(target.value as SortKey); diff --git a/extensions/ql-vscode/src/view/variant-analysis/VariantAnalysisActions.tsx b/extensions/ql-vscode/src/view/variant-analysis/VariantAnalysisActions.tsx index abec9443946..bf7261d5149 100644 --- a/extensions/ql-vscode/src/view/variant-analysis/VariantAnalysisActions.tsx +++ b/extensions/ql-vscode/src/view/variant-analysis/VariantAnalysisActions.tsx @@ -102,7 +102,6 @@ export const VariantAnalysisActions = ({ })}